Re: Knngist for 8.5

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Oleg Bartunov <oleg(at)sai(dot)msu(dot)su>
Cc: Mark Cave-Ayland <mark(dot)cave-ayland(at)siriusit(dot)co(dot)uk>, Teodor Sigaev <teodor(at)sigaev(dot)ru>, Josh Berkus <josh(at)agliodbs(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Knngist for 8.5
Date: 2010-02-08 04:41:31
Message-ID: 603c8f071002072041p5a66e0b3n7fc96bf59fe1a1dd@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

2010/2/7 Oleg Bartunov <oleg(at)sai(dot)msu(dot)su>:
> I understand your complaints. I think, the real problem is that some of us
> live in the part of word with long holidays in December, while we in Russia
> have very long holidays in January. So, about a month we couldn't
> synchronize developers and reviewers.  I'm not sure if we took this into
> account.

Yeah, that definitely made things harder. I had the feeling when I
started looking at this stuff over Christmas that it was going to take
a really determined and non-stop effort to get it all done, and we
haven't quite had that, either on the reviewing end or on your end.
Your holidays slowed things down, but we also had a quite small pool
of round-robin reviewers for this CF, and I couldn't get anyone to
sign on for knngist. Mark Cave-Ayland eventually volunteered but that
was relatively late, and then he hasn't posted anything yet because he
got involved in helping with rbtree (which by the way isn't quite
done; we should really try to finish that up). So I think it was a
combination of things.

By the way, I wish I had your holiday schedule! Can you send me a few of those?

> In regard to the knngist patch I want to claim, that I and Teodor are here
> and willing to answer any questions.

I really hope that Mark (or someone else) will post a review before
this CommitFest is over. I believe it is out of reach to get this
committed for this CF, but it would sure be nice to see it get at
least some review. I would like to review it myself at some point,
but I think right now I need to focus on things that are a little
further along and have a better chance of getting in.

...Robert

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2010-02-08 04:53:23 Re: [HACKERS] Re: Faster CREATE DATABASE by delaying fsync (was 8.4.1 ubuntu karmic slow createdb)
Previous Message Tom Lane 2010-02-08 04:33:55 pgsql: Remove old-style VACUUM FULL (which was known for a little while