From:
Robert Haas <robertmhaas(at)gmail(dot)com>
To:
KaiGai Kohei <kaigai(at)ak(dot)jp(dot)nec(dot)com>
Cc:
Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, KaiGai Kohei <kaigai(at)kaigai(dot)gr(dot)jp>, Bernd Helmle <mailings(at)oopsware(dot)de>, pgsql-hackers(at)postgresql(dot)org, Thom Brown <thombrown(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>
Subject:
Re: [BUG?] strange behavior in ALTER TABLE ... RENAME TO on inherited columns
Date:
2010-02-02 02:44:20
Message-ID:
603c8f071002011844r1eba44b4x1cd938fe25ac3f2@mail.gmail.com (view raw or flat )
Thread:
2009-11-04 06:36:15 from KaiGai Kohei <kaigai(at)ak(dot)jp(dot)nec(dot)com>
2009-11-04 13:31:36 from Alvaro Herrera <alvherre(at)commandprompt(dot)com>
2009-11-04 13:48:10 from Thom Brown <thombrown(at)gmail(dot)com>
2009-11-04 14:41:31 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2009-11-05 00:57:03 from KaiGai Kohei <kaigai(at)ak(dot)jp(dot)nec(dot)com>
2009-12-17 04:30:00 from KaiGai Kohei <kaigai(at)ak(dot)jp(dot)nec(dot)com>
2009-12-30 01:38:40 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-01-02 15:16:35 from KaiGai Kohei <kaigai(at)kaigai(dot)gr(dot)jp>
2010-01-02 19:32:36 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2010-01-03 14:53:41 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-01-03 17:31:10 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2010-01-03 19:06:04 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-01-03 23:58:22 from KaiGai Kohei <kaigai(at)ak(dot)jp(dot)nec(dot)com>
2010-01-04 03:41:49 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-01-04 04:18:26 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2010-01-04 04:52:09 from KaiGai Kohei <kaigai(at)ak(dot)jp(dot)nec(dot)com>
2010-01-04 09:55:16 from KaiGai Kohei <kaigai(at)ak(dot)jp(dot)nec(dot)com>
2010-01-14 03:43:27 from KaiGai Kohei <kaigai(at)ak(dot)jp(dot)nec(dot)com>
2010-01-14 07:04:17 from KaiGai Kohei <kaigai(at)ak(dot)jp(dot)nec(dot)com>
2010-01-23 18:45:11 from Bernd Helmle <mailings(at)oopsware(dot)de>
2010-01-24 03:29:23 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-01-24 03:48:35 from KaiGai Kohei <kaigai(at)kaigai(dot)gr(dot)jp>
2010-01-24 13:36:38 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-01-24 13:37:13 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-01-24 18:09:54 from Bernd Helmle <mailings(at)oopsware(dot)de>
2010-01-24 18:23:14 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2010-01-24 18:45:33 from Bernd Helmle <mailings(at)oopsware(dot)de>
2010-01-24 19:01:10 from Bernd Helmle <mailings(at)oopsware(dot)de>
2010-01-24 19:30:30 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-01-24 23:45:38 from KaiGai Kohei <kaigai(at)ak(dot)jp(dot)nec(dot)com>
2010-01-25 02:39:21 from KaiGai Kohei <kaigai(at)ak(dot)jp(dot)nec(dot)com>
2010-01-25 05:08:35 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-01-25 05:29:12 from KaiGai Kohei <kaigai(at)ak(dot)jp(dot)nec(dot)com>
2010-01-25 15:58:14 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-01-25 16:11:22 from Bernd Helmle <mailings(at)oopsware(dot)de>
2010-01-26 01:10:58 from KaiGai Kohei <kaigai(at)ak(dot)jp(dot)nec(dot)com>
2010-01-27 08:50:19 from KaiGai Kohei <kaigai(at)ak(dot)jp(dot)nec(dot)com>
2010-01-27 14:29:06 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-01-27 15:17:45 from KaiGai Kohei <kaigai(at)kaigai(dot)gr(dot)jp>
2010-01-27 20:42:45 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-01-27 21:03:51 from Bernd Helmle <mailings(at)oopsware(dot)de>
2010-01-27 21:58:35 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-01-28 01:13:49 from KaiGai Kohei <kaigai(at)ak(dot)jp(dot)nec(dot)com>
2010-01-28 15:46:44 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-01-29 00:13:02 from KaiGai Kohei <kaigai(at)ak(dot)jp(dot)nec(dot)com>
2010-01-29 00:29:27 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-01-29 00:58:46 from KaiGai Kohei <kaigai(at)ak(dot)jp(dot)nec(dot)com>
2010-01-29 03:02:22 from KaiGai Kohei <kaigai(at)ak(dot)jp(dot)nec(dot)com>
2010-01-29 18:36:20 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-01-31 23:41:11 from KaiGai Kohei <kaigai(at)ak(dot)jp(dot)nec(dot)com>
2010-02-01 03:04:53 from KaiGai Kohei <kaigai(at)ak(dot)jp(dot)nec(dot)com>
2010-02-01 18:01:21 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-02-01 18:31:10 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2010-02-01 18:40:06 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-02-01 18:55:56 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-02-01 19:03:38 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2010-02-01 19:29:17 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-02-02 00:48:42 from KaiGai Kohei <kaigai(at)ak(dot)jp(dot)nec(dot)com>
2010-02-02 01:47:17 from KaiGai Kohei <kaigai(at)ak(dot)jp(dot)nec(dot)com>
2010-02-02 02:09:51 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2010-02-02 02:20:26 from KaiGai Kohei <kaigai(at)ak(dot)jp(dot)nec(dot)com>
2010-02-02 02:31:01 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-02-02 02:39:07 from KaiGai Kohei <kaigai(at)ak(dot)jp(dot)nec(dot)com>
2010-02-02 02:44:20 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-02-02 02:55:17 from KaiGai Kohei <kaigai(at)ak(dot)jp(dot)nec(dot)com>
2010-02-02 14:50:53 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-02-02 23:40:45 from KaiGai Kohei <kaigai(at)ak(dot)jp(dot)nec(dot)com>
2010-02-02 02:32:01 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2010-01-28 00:37:19 from KaiGai Kohei <kaigai(at)ak(dot)jp(dot)nec(dot)com>
2010-01-24 12:13:44 from Bernd Helmle <mailings(at)oopsware(dot)de>
2010-01-04 18:19:55 from Robert Haas <robertmhaas(at)gmail(dot)com>
Lists:
pgsql-hackers
2010/2/1 KaiGai Kohei <kaigai(at)ak(dot)jp(dot)nec(dot)com>:
> (2010/02/02 11:31), Robert Haas wrote:
>> 2010/2/1 KaiGai Kohei<kaigai(at)ak(dot)jp(dot)nec(dot)com>:
>>> (2010/02/02 11:09), Tom Lane wrote:
>>>> KaiGai Kohei<kaigai(at)ak(dot)jp(dot)nec(dot)com> writes:
>>>>> The attached one also clean up ATPrepAddColumn() and ATExecAddColumn() code,
>>>>> not only ATPrepAlterColumnType(), according to what I mentioned above.
>>>>
>>>> What exactly do you claim is wrong with the ADD COLUMN case?
>>>
>>> ADD COLUMN case works correctly, but it takes unnecessary loops,
>>> because the find_all_inheritors() didn't provide the value to be
>>> set on the new pg_attribute.attinhcount.
>>>
>>> I'm saying it can be rewritten in more graceful manner using the
>>> new expected_parents argument.
>>
>> The subject line of this thread is getting less and less appropriate
>> to the content thereof.
>>
>> I am not in favor of doing anything for 9.0 that is not a bug fix.
>
> Are you talking about ATPrepAddColumn() only? Or both of ATPrepAddColumn()
> and ATPrepAlterColumnType()?
>
> My motivation to clean up ATPrepAddColumn() is less than the bugfix.
I'm making a general statement - if something is BROKEN (like the
rename case we just dealt with), we should look at fixing it. If it's
just something that could be cleaned up or done more nicely, we should
leave it alone for now.
...Robert
In response to
Responses
pgsql-hackers by date
Next :From: Alex HunsakerDate: 2010-02-02 02:53:05Subject : Re: Package namespace and Safe init cleanup for plperl UPDATE 3 [PATCH]Previous :From : KaiGai KoheiDate : 2010-02-02 02:39:07Subject : Re: [BUG?] strange behavior in ALTER TABLE ... RENAME TO
on inherited columns
