2010/2/1 KaiGai Kohei <kaigai(at)ak(dot)jp(dot)nec(dot)com>:
> (2010/02/02 11:09), Tom Lane wrote:
>> KaiGai Kohei<kaigai(at)ak(dot)jp(dot)nec(dot)com> writes:
>>> The attached one also clean up ATPrepAddColumn() and ATExecAddColumn() code,
>>> not only ATPrepAlterColumnType(), according to what I mentioned above.
>> What exactly do you claim is wrong with the ADD COLUMN case?
> ADD COLUMN case works correctly, but it takes unnecessary loops,
> because the find_all_inheritors() didn't provide the value to be
> set on the new pg_attribute.attinhcount.
> I'm saying it can be rewritten in more graceful manner using the
> new expected_parents argument.
The subject line of this thread is getting less and less appropriate
to the content thereof.
I am not in favor of doing anything for 9.0 that is not a bug fix.
In response to
pgsql-hackers by date
|Next:||From: Tom Lane||Date: 2010-02-02 02:32:01|
|Subject: Re: [BUG?] strange behavior in ALTER TABLE ... RENAME TO on inherited columns |
|Previous:||From: KaiGai Kohei||Date: 2010-02-02 02:20:26|
|Subject: Re: [BUG?] strange behavior in ALTER TABLE ... RENAME TO
on inherited columns|