Skip site navigation (1) Skip section navigation (2)

Re: attoptions

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Alex Hunsaker <badalex(at)gmail(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: attoptions
Date: 2010-01-21 02:51:32
Message-ID: 603c8f071001201851h19a88ec4n99291858fdf8ac5e@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-hackers
On Tue, Jan 19, 2010 at 10:51 AM, Alex Hunsaker <badalex(at)gmail(dot)com> wrote:
> But yes, lets keep it simple for now.

OK.  Updated patch attached.  Changes:

- Incorporate your previous review patch.
- Omit attacl and attoptions from hardcoded relation descriptor
initializers so the whole thing still builds.- Use
ATSimplePermissionsRelationOrIndex instead of custom permissions
logic.
- Remove recursion, per further thought about a comment in your
original review - I agree that the recursive behavior is weird.
- Remove a stray reference to SET STATISTICS DISTINCT in the documentation.
- Bug fix: this wasn't working at all for index-expression columns.

...Robert

Attachment: attoptions-v3.patch
Description: text/x-patch (44.8 KB)

In response to

Responses

pgsql-hackers by date

Next:From: Fujii MasaoDate: 2010-01-21 02:54:54
Subject: Re: Streaming Replication and archiving
Previous:From: Fujii MasaoDate: 2010-01-21 02:42:03
Subject: Re: HS/SR and smart shutdown

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group