Skip site navigation (1) Skip section navigation (2)

Re: attoptions

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Alex Hunsaker <badalex(at)gmail(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: attoptions
Date: 2010-01-19 20:06:06
Message-ID: 603c8f071001191206x56b3876dj97362477319d1617@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-hackers
On Fri, Jan 15, 2010 at 12:52 AM, Alex Hunsaker <badalex(at)gmail(dot)com> wrote:
> ***************
> *** 152,158 **** CATALOG(pg_attribute,1249) BKI_BOOTSTRAP
> BKI_WITHOUT_OIDS BKI_ROWTYPE_OID(75) BK
>        aclitem         attacl[1];
>
>        /* Column-level options */
> !       aclitem         attoptions[1];
>  } FormData_pg_attribute;
>
>  /*
> --- 152,158 ----
>        aclitem         attacl[1];
>
>        /* Column-level options */
> !       text            attoptions[1];
>  } FormData_pg_attribute;
>
>  /*

Unfortunately this change (which is obviously correct and necessary)
breaks the build on src/backend/catalog/heap.c with:

heap.c:122: error: missing braces around initializer
heap.c:122: error: (near initialization for ‘a1.attoptions[0]’)

...repeated of the 7 hard-coded descriptors.  Sadly I'm not quite sure
what to use instead.  I can't find any examples of static initializers
for a varlena (which text is).  However, I think that it doesn't
actually matter how that gets initialized, because I think only the
fixed-size portion is ever examined, so perhaps I can just leave off
the attoptions and attacl initializers altogether.

Whatever we decide about this, genbki.pl also needs the same treatment.

...Robert

In response to

Responses

pgsql-hackers by date

Next:From: Jeff DavisDate: 2010-01-19 20:07:46
Subject: Re: MySQL-ism help patch for psql
Previous:From: Hitoshi HaradaDate: 2010-01-19 20:02:16
Subject: Re: review: More frame options in window functions

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group