Skip site navigation (1) Skip section navigation (2)

Re: Largeobject Access Controls (r2460)

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Takahiro Itagaki <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>
Cc: KaiGai Kohei <kaigai(at)ak(dot)jp(dot)nec(dot)com>, Jaime Casanova <jcasanov(at)systemguards(dot)com(dot)ec>, Greg Smith <greg(at)2ndquadrant(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Largeobject Access Controls (r2460)
Date: 2009-12-18 04:11:56
Message-ID: 603c8f070912172011g75ba91b7ud758e1543b2b672d@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-hackers
On Thu, Dec 17, 2009 at 7:27 PM, Takahiro Itagaki
<itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp> wrote:
>> > Another comment is I'd like to keep <link linkend="catalog-pg-largeobject-metadata">
>> > for the first <structname>pg_largeobject</structname> in each topic.
>> Those two things aren't the same.  Perhaps you meant <link
>> linkend="catalog-pg-largeobject">?
> Oops, yes. Thank you for the correction.
>
> We also have "8.4.x series" in the core code. Do you think we also
> rewrite those messages? One of them is an use-visible message.

Yes.  I started going through the comments tonight.  Partial patch
attached.  There were two comments that I was unable to understand and
therefore could not reword - the one at the top of
pg_largeobject_aclmask_snapshot(), and the second part of the comment
at the top of LargeObjectExists():

 * Note that LargeObjectExists always scans the system catalog
 * with SnapshotNow, so it is unavailable to use to check
 * existence in read-only accesses.

In both cases, I'm lost.  Help?

In acldefault(), there is this comment:

  /* Grant SELECT,UPDATE by default, for now */

This doesn't seem to match what the code is doing, so I think we
should remove it.

I also notice that dumpBlobComments() is now misnamed, but it seems
we've chosen to add a comment
mentioning that fact rather than fixing it.  That doesn't seem like
the right approach.

...Robert

Attachment: lo_comments.patch
Description: text/x-patch (3.8 KB)

In response to

Responses

pgsql-hackers by date

Next:From: KaiGai KoheiDate: 2009-12-18 06:05:08
Subject: Re: [PATCH] remove redundant ownership checks
Previous:From: Robert HaasDate: 2009-12-18 03:16:30
Subject: Re: [PATCH] remove redundant ownership checks

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group