Re: pgsql: Add an EXPLAIN (BUFFERS) option to show buffer-usage statistics.

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Simon Riggs <simon(at)2ndquadrant(dot)com>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Add an EXPLAIN (BUFFERS) option to show buffer-usage statistics.
Date: 2009-12-15 20:36:25
Message-ID: 603c8f070912151236m64e2f621i1c783e2df5f2bc07@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Tue, Dec 15, 2009 at 1:32 PM, Simon Riggs <simon(at)2ndquadrant(dot)com> wrote:
> On Tue, 2009-12-15 at 04:57 +0000, Robert Haas wrote:
>> This patch also removes buffer-usage statistics from the track_counts
>> output, since this (or the global server statistics) is deemed to be a
>> better interface to this information.
>
> I hope anything being removed is documented, though I don't see that.
> Do you mean pg_statio_* tables no longer track heap_blocks* ? That is my
> understanding of what track_counts gives us. I think you mean
> log_*_stats, which is something else entirely.

Oops. You're right, it's log_*_stats, rather than track_counts().
Unfortunately, the format of the log_*_stats output is not documented:
we can't remove this from the list of things that log_*_stats is
documented to print, because there is no such list. That might be
worth correcting, but the lack of pre-existing documentation didn't
seem like something this patch should try to fix.

...Robert

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2009-12-15 20:37:17 pgsql: Avoid unnecessary copying of source string when generating a
Previous Message Tom Lane 2009-12-15 20:04:50 pgsql: Add a hook to let loadable modules get control at ProcessUtility