| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
| Cc: | Marko Tiikkaja <marko(dot)tiikkaja(at)cs(dot)helsinki(dot)fi>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Using results from INSERT ... RETURNING |
| Date: | 2009-09-29 16:32:56 |
| Message-ID: | 603c8f070909290932o6ba2b5e4x3fa96db66537a2a3@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Sep 29, 2009 at 11:29 AM, Alvaro Herrera
<alvherre(at)commandprompt(dot)com> wrote:
> Marko Tiikkaja escribió:
>> Robert Haas wrote:
>> >So I think we should at a minimum ask the patch author to (1) fix the
>> >explain bugs I found and (2) update the README, as well as (3) revert
>> >needless whitespace changes - there are a couple in execMain.c, from
>> >the looks of it.
>>
>> In the attached patch, I made the changes to explain as you
>> suggested and reverted the only whitespace change I could find from
>> execMain.c. However, English isn't my first language so I'm not very
>> confident about fixing the README.
>
> BTW what was the conclusion of the idea about having three separate
> nodes Insert, Delete, Update instead of a single Dml node?
It wasn't obvious from reading the patch why multiple node types would
be superior; but I'm not 100% sure I understand what Tom had in mind,
either.
...Robert
| From | Date | Subject | |
|---|---|---|---|
| Next Message | kunal sharma | 2009-09-29 16:35:23 | Re: [HACKERS] Postgres server goes in recovery mode repeteadly |
| Previous Message | Tom Lane | 2009-09-29 16:28:03 | Re: Postgres server goes in recovery mode repeteadly |