Skip site navigation (1) Skip section navigation (2)

Re: operator exclusion constraints [was: generalized index constraints]

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Jeff Davis <pgsql(at)j-davis(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: operator exclusion constraints [was: generalized index constraints]
Date: 2009-09-27 17:02:30
Message-ID: 603c8f070909271002n477a9d26md65b560bfc2f8d6e@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-hackers
On Wed, Sep 23, 2009 at 1:47 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Jeff Davis <pgsql(at)j-davis(dot)com> writes:
>> We can either eliminate the USING variant from opt_class (unless it's
>> necessary for some reason or I missed it in the documentation), or we
>> can use another word (e.g. WITH or WITH OPERATOR) if you don't like
>> CHECK.
>
> Hmm ... we don't seem to have documented the USING noise-word, so it
> probably would be safe to remove it; but why take a chance?  I don't
> particularly agree with Peter's objection to CHECK.  There are plenty
> of examples in SQL of the same keyword being used for different purposes
> in nearby places.  Indeed you could make about the same argument to
> object to USING, since it'd still be there in "USING access_method"
> elsewhere in the same command.
>
> I think that USING is just about as content-free as WITH in this
> particular example --- it doesn't give you any hint about what the
> purpose of the operator is.

USING might be just as content-free as WITH, but USING OPERATOR seems
clearly better, at least IMO.

Also, this patch has not been updated in a week, and the clock is
ticking: if we don't have an updated version RSN, we need to move this
to Returned with Feedback and wait until next CommitFest.  That would
be too bad; this is an awesome feature.

Thanks,

...Robert

In response to

Responses

pgsql-hackers by date

Next:From: Tom LaneDate: 2009-09-27 17:08:20
Subject: Re: operator exclusion constraints [was: generalized index constraints]
Previous:From: Robert HaasDate: 2009-09-27 16:58:26
Subject: Re: [PATCH] Largeobject access controls

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group