From:
Robert Haas <robertmhaas(at)gmail(dot)com>
To:
Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc:
Alvaro Herrera <alvherre(at)commandprompt(dot)com>, pgsql-committers(at)postgresql(dot)org
Subject:
Re: pgsql: Refactor NUM_cache_remove calls in error report path to a PG_TRY
Date:
2009-08-10 21:39:30
Message-ID:
603c8f070908101439x2adece70t2efad37f8100be32@mail.gmail.com (view raw or flat )
Thread:
2009-08-10 20:16:05 from alvherre(at)postgresql(dot)org (Alvaro Herrera)
2009-08-10 20:17:58 from Robert Haas <robertmhaas(at)gmail(dot)com>
2009-08-10 20:22:47 from Alvaro Herrera <alvherre(at)commandprompt(dot)com>
2009-08-10 20:31:43 from Robert Haas <robertmhaas(at)gmail(dot)com>
2009-08-10 23:08:04 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2009-08-10 20:31:55 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2009-08-10 21:39:30 from Robert Haas <robertmhaas(at)gmail(dot)com>
2009-08-10 22:03:11 from Alvaro Herrera <alvherre(at)commandprompt(dot)com>
2009-08-10 22:52:04 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2009-08-11 03:40:04 from Robert Haas <robertmhaas(at)gmail(dot)com>
2009-08-11 15:56:18 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2009-08-11 16:43:09 from Robert Haas <robertmhaas(at)gmail(dot)com>
2009-08-11 16:52:37 from Andrew Dunstan <andrew(at)dunslane(dot)net>
2009-08-11 17:42:08 from Robert Haas <robertmhaas(at)gmail(dot)com>
2009-08-11 18:33:41 from Andrew Dunstan <andrew(at)dunslane(dot)net>
2009-08-11 18:53:15 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2009-08-11 19:19:01 from Andrew Dunstan <andrew(at)dunslane(dot)net>
2009-08-11 19:28:26 from Alvaro Herrera <alvherre(at)commandprompt(dot)com>
2009-08-11 19:51:33 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2009-08-11 23:06:04 from Bruce Momjian <bruce(at)momjian(dot)us>
2009-08-11 23:14:45 from Bruce Momjian <bruce(at)momjian(dot)us>
2009-08-11 23:12:50 from Bruce Momjian <bruce(at)momjian(dot)us>
2009-08-12 01:42:37 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2009-08-12 01:55:39 from Bruce Momjian <bruce(at)momjian(dot)us>
2009-08-12 00:10:01 from Greg Stark <gsstark(at)mit(dot)edu>
2009-08-12 01:05:29 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2009-08-12 01:29:26 from Robert Haas <robertmhaas(at)gmail(dot)com>
2009-08-12 01:42:50 from Andrew Dunstan <andrew(at)dunslane(dot)net>
2009-08-12 01:54:21 from Bruce Momjian <bruce(at)momjian(dot)us>
2009-08-12 02:08:58 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2009-08-12 02:49:23 from Robert Haas <robertmhaas(at)gmail(dot)com>
2009-08-12 04:27:16 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2009-08-12 04:54:40 from Alvaro Herrera <alvherre(at)commandprompt(dot)com>
2009-08-12 05:00:54 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2009-08-12 13:26:29 from Alvaro Herrera <alvherre(at)commandprompt(dot)com>
2009-08-12 13:35:30 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2009-08-12 13:56:37 from Robert Haas <robertmhaas(at)gmail(dot)com>
2009-08-12 13:34:41 from Robert Haas <robertmhaas(at)gmail(dot)com>
2009-08-12 13:38:30 from Alvaro Herrera <alvherre(at)commandprompt(dot)com>
2009-08-12 13:57:15 from Robert Haas <robertmhaas(at)gmail(dot)com>
2009-08-12 13:58:14 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Lists:
pgsql-committers pgsql-hackers
On Mon, Aug 10, 2009 at 4:31 PM, Tom Lane<tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
>> Robert Haas escribió:
>>>> The code in the new block was not reindented; it will be fixed by pgindent
>>>> eventually.
>>>
>>> ...breaking every patch that someone has in progress against that code?
>
>> I guess I neglected to add "a year from now or so". I'm not in a hurry
>> to run pgindent.
>
> Yeah --- if there are any active patches against that code (a fact not
> in evidence) then reindenting now would break them now. Leaving it till
> the next pgindent run seems fine to me.
But if there are patches against that code, then they've been broken
now and they will break again when the pgindent run is done. If the
indentation is fixed at commit-time (or before someone goes to the
trouble of fixing them), then they get broken only once. I guess it's
not the end of the world, but it sure seems like the less work
pgindent does when it is run, the better.
...Robert
In response to
Responses
pgsql-hackers by date
Next :From: Alvaro HerreraDate: 2009-08-10 22:03:11Subject : Re: [COMMITTERS] pgsql: Refactor NUM_cache_remove calls in error
report path to a PG_TRYPrevious :From : Stephen FrostDate : 2009-08-10 21:28:42Subject : Re: GRANT ON ALL IN schema
pgsql-committers by date
Next :From: Alvaro HerreraDate: 2009-08-10 22:03:11Subject : Re: [COMMITTERS] pgsql: Refactor NUM_cache_remove calls in error
report path to a PG_TRYPrevious :From : Tom LaneDate : 2009-08-10 20:31:55Subject : Re: pgsql: Refactor NUM_cache_remove calls in error report path to a PG_TRY
