Re: pgsql: Refactor NUM_cache_remove calls in error report path to a PG_TRY

On Mon, Aug 10, 2009 at 4:22 PM, Alvaro
Herrera<alvherre(at)commandprompt(dot)com> wrote:
> Robert Haas escribió:
>> On Mon, Aug 10, 2009 at 4:16 PM, Alvaro Herrera<alvherre(at)postgresql(dot)org> wrote:
>> > Log Message:
>> > -----------
>> > Refactor NUM_cache_remove calls in error report path to a PG_TRY block.
>> >
>> > The code in the new block was not reindented; it will be fixed by pgindent
>> > eventually.
>>
>> ...breaking every patch that someone has in progress against that code?
>
> I guess I neglected to add "a year from now or so".  I'm not in a hurry
> to run pgindent.

Me neither, but every place that we know pgindent will touch is like a
little land-mine waiting to go off under somebody's patch. It seems
like we ought to try to keep the tree as pgindent-clean as possible
when we make changes, so that there are as few of those land-mines out
there as possible.

...Robert