Skip site navigation (1) Skip section navigation (2)

Re: explain refactoring v4

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: explain refactoring v4
Date: 2009-07-24 21:11:51
Message-ID: 603c8f070907241411w778030b3jdbd1f75071926827@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-hackers
On Fri, Jul 24, 2009 at 4:02 PM, Tom Lane<tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>> OK, here it is again.  Changes are the same as the previous version,
>> but this one should apply cleanly after today's pgindent run.
>
> As I was poking through this I noticed that it makes at least one small
> change in the output format: what had been "Subquery Scan ss" will now
> be "Subquery Scan on ss", because of the unification of code that wasn't
> really entirely consistent into one subroutine ExplainScanTarget.

Wow, nice catch.

> This is not likely to matter to human readers but it might to programs.
> OTOH we presumably expect programs to migrate to using a more
> program-friendly EXPLAIN output format with 8.5.
>
> Does anyone have strong feelings about whether we need to be
> bug-compatible with the old formatting?

I kind of doubt it.  Based on previous discussions, I gather that
PGadmin et al have to be adjusted for each release anyway.  But I also
don't think it's a big deal if we make it work the way it used to.

...Robert

In response to

Responses

pgsql-hackers by date

Next:From: Robert HaasDate: 2009-07-24 21:15:14
Subject: Re: explain refactoring v4
Previous:From: Tom LaneDate: 2009-07-24 21:11:21
Subject: Re: explain refactoring v4

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group