Skip site navigation (1) Skip section navigation (2)

Re: need more reviewers for index changes

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Stephen Frost <sfrost(at)snowman(dot)net>
Cc: Jaime Casanova <jcasanov(at)systemguards(dot)com(dot)ec>, pgsql-rrreviewers(at)postgresql(dot)org
Subject: Re: need more reviewers for index changes
Date: 2009-07-21 17:08:55
Message-ID: 603c8f070907211008j40bfe769s2ca7f3d025dc935a@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-rrreviewers
On Tue, Jul 21, 2009 at 6:40 AM, Stephen Frost<sfrost(at)snowman(dot)net> wrote:
> Robert,
>
> * Robert Haas (robertmhaas(at)gmail(dot)com) wrote:
>> It probably makes sense to start with indexam api changes, since the
>> other one depends on that one.
>
> I've looked the patch over, but the problem is that the patch doesn't do
> terribly much by itself, and Tom's already commented on things he
> doesn't like about it.  Alot of the patch here:
> http://archives.postgresql.org/message-id/4A5ADFE6.6060507@enterprisedb.com
> is changing heap_hot_search_buffer to have heapTuple passed in as a
> pointer rather than a local var, which makes for many '.' to '->'
> changes.  The rest is just splitting index_getnext into two pieces.

Ah, yes, I see your point.  So I think this is actually waiting on
author.  We should poke Heikki.

...Robert

In response to

Responses

pgsql-rrreviewers by date

Next:From: Jaime CasanovaDate: 2009-07-21 17:44:24
Subject: Re: CF 2009-07: initial reviewing assignments
Previous:From: Robert HaasDate: 2009-07-21 17:06:56
Subject: Re: CF 2009-07: initial reviewing assignments

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group