On Wed, Jul 15, 2009 at 11:44 PM, Alex Hunsaker<badalex(at)gmail(dot)com> wrote:
> On Mon, Dec 8, 2008 at 06:56, Pavan Deolasee<pavan(dot)deolasee(at)gmail(dot)com> wrote:
>> Here is a patch which implements this. The PD_ALL_VISIBLE flag is set if all
>> tuples in the page are visible to all transactions and there are no DEAD
>> line pointers in the page. The second check is required so that VACUUM takes
>> up the page. We could slightly distinguish the two cases (one where the page
>> requires vacuuming only because of DEAD line pointers and the other where
>> the page-tuples do not require any visibility checks), but I thought its not
>> worth the complexity.
> I was round robin assigned to review this. So take my comments with
> the grain of salt (or novice HOT salt) they deserve.
Pavan, are you planning to respond to Alex's comments and/or update this patch?
In response to
pgsql-hackers by date
|Next:||From: Itagaki Takahiro||Date: 2009-07-21 05:23:54|
|Subject: Re: pg_restore --clean vs. large object|
|Previous:||From: Itagaki Takahiro||Date: 2009-07-21 05:07:47|
|Subject: Re: Duplicate key value error|