Skip site navigation (1) Skip section navigation (2)

Re: dependencies for generated header files

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: pgsql-hackers(at)postgresql(dot)org
Subject: Re: dependencies for generated header files
Date: 2009-06-29 02:41:57
Message-ID: 603c8f070906281941s57b626b1t6076a8c81985e1ab@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-hackers
On Sun, Jun 28, 2009 at 2:21 PM, Robert Haas<robertmhaas(at)gmail(dot)com> wrote:
> I think that our dependencies for generated header files (gram.h,
> fmgroids.h, probes.h) are not as good as they could be.  What we do
> right now is make src/backend/Makefile rebuild these before recursing
> through its subdirectories.  This works OK for a top-level make, but
> if you run make further down in the tree (like under
> src/backend/commands) it won't necessarily rebuild everything that it
> should.
>
> The attached patch moves some of this logic from src/backend/Makefile
> to src/Makefile.global.in.  That way, if you --enable-depend and then
> do something like "touch src/include/catalog/pg_proc.h" and then "cd
> src/backend/commands; make vacuum.o", it rebuilds fmgroids.h and then
> recompiles vacuum.c.  Under HEAD, it just tells you that vacuum.o is
> up to date.
>
> I have tested this on vpath and non-vpath builds, with and without
> --enable-depend.

Woops.  It seems that patch generates some warnings on a vpath build
which I failed to notice.  Corrected version that guards against same
is attached.

...Robert

Attachment: header_depend-v2.patch
Description: text/x-diff (3.5 KB)

In response to

Responses

pgsql-hackers by date

Next:From: Itagaki TakahiroDate: 2009-06-29 03:42:16
Subject: Re: query cancel issues in contrib/dblink
Previous:From: KaiGai KoheiDate: 2009-06-28 23:32:29
Subject: Re: [PATCH] [v8.5] Security checks on largeobjects

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group