Skip site navigation (1) Skip section navigation (2)

explain refactoring v4

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: pgsql-hackers(at)postgresql(dot)org
Subject: explain refactoring v4
Date: 2009-06-12 04:32:11
Message-ID: 603c8f070906112132v16c03ca9t8a9f08f561bf3909@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-hackers
OK, here it is again.  Changes are the same as the previous version,
but this one should apply cleanly after today's pgindent run.

http://archives.postgresql.org/message-id/603c8f070906051803nd4a9e3ekb72bcc379ad73f16@mail.gmail.com

(Rebasing this wasn't too bad, but I have to say that one thing that's
frustrating is that there's no obvious rule for how continuation lines
should be indented.  If it were easy for patch authors and committers
to understand what to do, pgindent would change less stuff, which
would make for less rebasing.  Just to take one example, in explain.h,
the level of hanging indent for the parameters of ExplainOnePlan is
different than the level for ExplainPrintPlan.  That's presumably
because ExplainPrintPlan is two characters longer than ExplainOnePlan,
but beyond that I'm lost.)

...Robert

Attachment: explain_refactor_v4.patch
Description: text/x-diff (36.0 KB)

Responses

pgsql-hackers by date

Next:From: Robert HaasDate: 2009-06-12 04:41:24
Subject: generic explain options v2
Previous:From: suylivarDate: 2009-06-12 03:10:03
Subject: PostgreSQL installation

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group