Re: Recovery Test Framework

From: "Robert Haas" <robertmhaas(at)gmail(dot)com>
To: "Bruce Momjian" <bruce(at)momjian(dot)us>
Cc: "Gregory Stark" <stark(at)enterprisedb(dot)com>, "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "Christopher Browne" <cbbrowne(at)gmail(dot)com>, "Dave Page" <dpage(at)pgadmin(dot)org>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Recovery Test Framework
Date: 2009-01-13 04:14:01
Message-ID: 603c8f070901122014t38a9239fr1a6a44e3ceaa6d53@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> I am just explaining how it works in practice. If the patch is still
> being improved, the feeling is that the author wants more time to adjust
> things, and with other things on our plate, we are glad to leave their
> patch until last.

Well, it's good that you have an explanation, but I'm not sure it
helps much. :-) Surely the patches that are most likely to change
substantially are the big ones, and leaving those until last results
in them not making the time-based cutoff. Someone who submitted a
20-line patch isn't likely to revise it substantially; someone who is
being paid $20k to write a patch is likely to spend a lot of time
working on it.

I think the fundamental problem here is the number and bandwidth of
the committers, which seems to be pretty limited. Most of the
committers are either inactive, or essentially maintainers for a
particular subsystem. With the exception of patches authored by the
committers themselves, I think the vast majority of patches for this
'fest were committed by Tom and Peter - and I think really mostly Tom.
And many of those were significantly modified in the process of being
committed, which suggests that efforts to take the load of committers
by having non-committers do reviews has not been entirely successful.
(It would be interesting to here how much value people think it has
added, and get suggestions on how to do things better next time.)

I'm not sure what to do about it, though. More committers could be
added, but I presume if there were obvious candidates it would have
been done already. It's complicated by the fact that you need people
who both (1) know what they're doing and (2) have time to review and
commit *other people's patches*. In reality, a pretty significant
fraction of the current committers are either mostly inactive, or
essentially maintainers for one small area of the code.

...Robert

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2009-01-13 04:16:28 Re: New patch for Column-level privileges
Previous Message KaiGai Kohei 2009-01-13 03:54:12 Re: New patch for Column-level privileges