> I had a deeper look at this now. The patch looks clean and applies without
> any problems, regression tests passes. However, ATRewriteTables() has a
> problem when adding columns with domains and constraints. Consider this
> small test case:
>
> CREATE TABLE bar (id INTEGER);
> CREATE OR REPLACE VIEW vbar AS SELECT * FROM bar;
> CREATE DOMAIN person AS TEXT CHECK(value IN ('haas', 'helmle'));
> ALTER TABLE bar ADD COLUMN name person;
> CREATE OR REPLACE VIEW vbar AS SELECT * FROM bar;
>
> The last command confuses ATRewriteTable(), which wants to scan the relation
> leading to this error:
> ERROR:  could not open relation base/16384/16476:
>
> I see that ATRewriteTable() errors out on heap_beginscan(), since needscan
> is set to TRUE. One solution would be to teach ATRewriteTable(s) to handle
> view alteration differently in this case.

After looking at this, I think the root cause of this problem is that
ATPrepAddColumn isn't smart enough to know that when the underlying
relation is a view, there's no point in asking for a table rewrite.
Please find an updated patch that addresses this problem.

Thanks again for the review - let me know what you think of this version!

...Robert

In response to

• Re: patch: Add columns via CREATE OR REPLACE VIEW at 2008-11-27 13:34:56 from Bernd Helmle

Responses

• Re: patch: Add columns via CREATE OR REPLACE VIEW at 2008-12-06 23:23:10 from Bruce Momjian

pgsql-hackers by date

Next:	From: Robert Haas	Date: 2008-12-02 01:57:33
	Subject: Re: broken URL in commitfest page
Previous:	From: Raymond O'Donnell	Date: 2008-12-01 22:33:14
	Subject: Re: [pgsql-www] Reg: Nested query