Skip site navigation (1) Skip section navigation (2)

Re: Fwd: [Patch Review] TRUNCATE Permission

From: "Robert Haas" <robertmhaas(at)gmail(dot)com>
To: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: "Ryan Bradetich" <rbradetich(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Fwd: [Patch Review] TRUNCATE Permission
Date: 2008-09-06 03:13:25
Message-ID: 603c8f070809052013l2f350eecn15c21d490a8f6d18@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-hackers
Updated patch attached, based on comments from Ryan Bradetich and Tom
Lane, and sync'd to latest CVS version.

...Robert

On Mon, Sep 1, 2008 at 9:33 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> "Ryan Bradetich" <rbradetich(at)gmail(dot)com> writes:
>> On Mon, Sep 1, 2008 at 1:00 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>>> [ something about "your patch" ]
>
>> This is Robert Haas's patch for the September 2008 commit-fest.
>> I am just offering my review.
>
> Sorry about that, I got confused by the reply-to-a-reply.
>
>> Does my first suggestion still make sense for removing the TRUNCATE in
>> pg_class_aclmask() when pg_Authid.rolcatupdate is not set?
>
> Probably.  AFAICS it should be treated exactly like ACL_DELETE, so
> anyplace that acl-whacking code is doing something for ACL_DELETE and
> the patch doesn't add in ACL_TRUNCATE, I'd be suspicious ...
>
>                        regards, tom lane
>
> --
> Sent via pgsql-hackers mailing list (pgsql-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgsql-hackers
>

Attachment: truncate-v2.patch
Description: text/x-diff (27.2 KB)

In response to

Responses

pgsql-hackers by date

Next:From: Tom LaneDate: 2008-09-06 05:20:17
Subject: Re: [PATCH] "\ef <function>" in psql
Previous:From: Brendan JurdDate: 2008-09-06 02:43:39
Subject: Re: [PATCH] "\ef <function>" in psql

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group