Skip site navigation (1) Skip section navigation (2)

Re: pg_restore recognizing $-quotes

From: Philip Warner <pjw(at)rhyme(dot)com(dot)au>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: pgsql-patches(at)postgresql(dot)org, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Subject: Re: pg_restore recognizing $-quotes
Date: 2004-08-18 12:01:24
Message-ID: 6.1.1.1.0.20040818215835.054ac340@203.8.195.10 (view raw or flat)
Thread:
Lists: pgsql-patches
At 01:44 PM 18/08/2004, Bruce Momjian wrote:
>This is quite a large patch, but we do need a solution to this problem.
>Should it be applied?

It's not as large as you might think; I had to indent a large chunk of 
code, and that shows up in the diff. Try applying it, and looking at a 
'diff -b'.

There are two issues that I can see:

  - I think the logic used to check for $-quotes is valid, but someone
    else should look at it.

  - Adding a full parser would be too big a change for now; and should
    be avoided if possible.






----------------------------------------------------------------
Philip Warner                    |     __---_____
Albatross Consulting Pty. Ltd.   |----/       -  \
(A.B.N. 75 008 659 498)          |          /(@)   ______---_
Tel: (+61) 0500 83 82 81         |                 _________  \
Fax: (+61) 03 5330 3172          |                 ___________ |
Http://www.rhyme.com.au          |                /           \|
                                  |    --________--
PGP key available upon request,  |  /
and from pgp.mit.edu:11371       |/ 


In response to

pgsql-patches by date

Next:From: Karel ZakDate: 2004-08-18 13:42:05
Subject: 8.0 libpq: missing get_home_path()
Previous:From: Andrew DunstanDate: 2004-08-18 10:39:44
Subject: Re: pg_restore recognizing $-quotes

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group