Re: preliminary: logical column order

From: Manfred Koizar <mkoi-pg(at)aon(dot)at>
To: Neil Conway <neilc(at)samurai(dot)com>
Cc: PostgreSQL Patches <pgsql-patches(at)postgresql(dot)org>, Dave Cramer <davec(at)fastcrypt(dot)com>
Subject: Re: preliminary: logical column order
Date: 2003-11-24 07:47:29
Message-ID: 5kd3svcfcgfl7lu9r5a7l7opon7bp8cqvu@email.aon.at
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

On Fri, 21 Nov 2003 03:09:02 -0500, Neil Conway <neilc(at)samurai(dot)com> wrote:
>attachment; filename=weird_regression.diffs

This was caused by a small oversight in ALTER TABLE ... ADD COLUMN:

diff -ruN ../base/src/backend/commands/tablecmds.c src/backend/commands/tablecmds.c
--- ../base/src/backend/commands/tablecmds.c 2003-10-14 00:47:15.000000000 +0200
+++ src/backend/commands/tablecmds.c 2003-11-23 16:51:37.000000000 +0100
@@ -1786,6 +1786,7 @@
attribute->attcacheoff = -1;
attribute->atttypmod = colDef->typename->typmod;
attribute->attnum = i;
+ attribute->attpos = i;
attribute->attbyval = tform->typbyval;
attribute->attndims = attndims;
attribute->attisset = (bool) (tform->typtype == 'c');

Servus
Manfred

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Robert Treat 2003-11-25 14:18:21 minor cleanup in plpgsql.sgml
Previous Message Anjan Dave 2003-11-24 03:51:10 file too large, segmentation fault