Skip site navigation (1) Skip section navigation (2)

Re: arrays as pl/perl input arguments [PATCH]

From: Alexey Klyukin <alexk(at)commandprompt(dot)com>
To: Alex Hunsaker <badalex(at)gmail(dot)com>
Cc: Andrew Dunstan <andrew(at)dunslane(dot)net>, "David E(dot) Wheeler" <david(at)kineticode(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: arrays as pl/perl input arguments [PATCH]
Date: 2011-02-15 14:39:07
Message-ID: 5B79700F-2C36-4F3B-B304-166F4C940EEF@commandprompt.com (view raw or flat)
Thread:
Lists: pgsql-hackers
On Feb 12, 2011, at 9:53 AM, Alex Hunsaker wrote:

> On Fri, Feb 11, 2011 at 17:17, Alexey Klyukin <alexk(at)commandprompt(dot)com> wrote:
> 
> Anyway in playing with this patch a bit more I found another bug
> return [[]]; would segfault.
> 
> So find attached a v9 that:
> - fixes above segfault
> 
> - made plperl_sv_to_literal vastly simpler (no longer uses SPI and
> calls regtypin directly)
> 
> - removed extraneous </para> added in v8 in plperl.sgml (my docbook
> stuff is broken, so I can't build them, hopefully there are no other
> problems)
> 
> - we now on the fly (when its requested) make the backwards compatible
> string for arrays (it was a few lines now that we have
> plperl_sv_to_literal)
> 
> - make plperl.o depend on plperl_helpers.h (should have been done in
> the utf8 patch)
> 
> Anyway barring any more bugs, I think this patch is ready.
> <pg_to_perl_arrays_v9.patch.gz>

Thank you for finding and fixing the bugs there. I think removing the para was a mistake.
I specifically added it to fix the problem I had when building the docs:

openjade:plperl.sgml:353:8:E: end tag for "PARA" omitted, but OMITTAG NO was specified
openjade:plperl.sgml:201:2: start tag was here

After I re-added the closing </para> in plperl.sgml:235 these errors disappeared, and the
resulting html looks fine too. v10 with just this single change is attached.


/A


--
Alexey Klyukin
The PostgreSQL Company - Command Prompt, Inc.

Attachment: pg_to_perl_arrays_v10.patch.gz
Description: application/x-gzip (17.9 KB)

In response to

Responses

pgsql-hackers by date

Next:From: Bruce MomjianDate: 2011-02-15 15:23:27
Subject: Re: pg_upgrade seems a tad broken
Previous:From: Bruce MomjianDate: 2011-02-15 14:25:39
Subject: Re: pg_upgrade seems a tad broken

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group