Re: pageinspect: Hash index support

From: Jesper Pedersen <jesper(dot)pedersen(at)redhat(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Jeff Janes <jeff(dot)janes(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pageinspect: Hash index support
Date: 2017-01-10 17:19:20
Message-ID: 59ce3337-075d-d8ee-fe33-280a4cc0700a@redhat.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 01/10/2017 10:39 AM, Tom Lane wrote:
> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>> No, you're missing the point. The patch doesn't need to add
>> pageinspect--1.6.sql at all, nor does it remove pageinspect--1.5.sql.
>> It only needs to add pageinspect--1.5--1.6.sql and change the default
>> version to 1.6. No other changes are required.
>
> Right, this is a new recommended process since commit 40b449ae8,
> which see for rationale.
>
> Use, eg, commit 11da83a0e as a model for extension update patches.
>

Thanks for the commit ids !

Revised patched attached.

Best regards,
Jesper

Attachment Content-Type Size
0001-Add-support-for-hash-index-in-pageinspect-contrib-mo_v3.patch text/x-patch 27.5 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2017-01-10 17:22:17 Re: [DOCS] Questionable tag usage
Previous Message Andrew Borodin 2017-01-10 17:13:32 Re: GSoC 2017