Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> This fix is surely wrong for several reasons:
> . the configure changes only broke MSVC builds, not all Windows builds 
> (see narwhal, for example), but this change applies to both.
> . fixing a change that adds a configure option by hardcoding it in 
> pg_config.h.win32 is simply the wrong fix - the right fix is to add the 
> equivalent logic to src/tools/Solution.pm.

Well, maybe the right answer is to take a step back and figure out what
pg_config.h.win32's excuse for living is at all.  I do not understand
our Windows configuration setup, and what I do understand is is that
it's a pile of horrid kluges that break anytime anyone looks at them
sideways.

I will be quite happy to never touch any Windows configuration stuff
again.  If you want me to, you had better redesign and/or document it
so that people other than you and Magnus have some idea of what connects
to what.

			regards, tom lane

In response to

• Re: pgsql: Sigh ... at 2008-05-02 07:57:43 from Andrew Dunstan

Responses

• Re: [COMMITTERS] pgsql: Sigh ... at 2008-05-02 19:27:05 from Andrew Dunstan

pgsql-hackers by date

Next:	From: Tom Lane	Date: 2008-05-02 14:52:36
	Subject: Re: Protection from SQL injection
Previous:	From: Andrew Sullivan	Date: 2008-05-02 14:25:09
	Subject: Re: Odd timezone backend output

pgsql-committers by date

Next:	From: User Fxjr	Date: 2008-05-02 15:00:44
	Subject: npgsql - Npgsql2: Added missing System.Transactions.dll assembly so
Previous:	From: Peter Eisentraut	Date: 2008-05-02 14:16:24
	Subject: pgsql: Make the AWK default value also take effect if $AWK is an empty

pgsql-patches by date

Next:	From: Simon Riggs	Date: 2008-05-02 15:03:32
	Subject: Re: GUC parameter cursors_tuple_fraction
Previous:	From: George Gensure	Date: 2008-05-02 14:33:29
	Subject: Re: pg_postmaster_reload_time() patch