Skip site navigation (1) Skip section navigation (2)

Re: [HACKERS] Performance testing of COPY (SELECT) TO

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
Cc: Hans-Juergen Schoenig <postgres(at)cybertec(dot)at>, Zoltan Boszormenyi <zboszor(at)dunaweb(dot)hu>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Bruce Momjian <bruce(at)momjian(dot)us>, pgsql-patches(at)postgresql(dot)org
Subject: Re: [HACKERS] Performance testing of COPY (SELECT) TO
Date: 2006-08-28 16:26:23
Message-ID: 5818.1156782383@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches
Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> My question is, if we allow this:
> copy (select * from view) to stdout;
> (or to a file, whatever), is it enough for you?  Or would you insist on
> also having
> copy view to stdout;
> ?

> We can, and the posted patch does, support the first form, but not the
> second.  In fact I deliberately removed support for the second form for
> Zoltn's patch because it uglifies the surrounding code.

Personally, I have no moral objection to supporting the second form
as a special case of the general COPY-from-select feature, but if it
can't be done without uglifying the code then I'd agree with dropping
it.  I guess the question is whether the uglification is intrinsic or
just a result of being descended from a poor original implementation.

The feature-freeze argument seems not relevant, given that the code
we had on the feature-freeze date did both things.

Has this patch settled to the point where I can review it, or is it
still in motion?

			regards, tom lane

In response to

Responses

pgsql-hackers by date

Next:From: Hans-Juergen SchoenigDate: 2006-08-28 16:26:52
Subject: Re: [HACKERS] Performance testing of COPY (SELECT) TO
Previous:From: Tom LaneDate: 2006-08-28 16:16:40
Subject: Re: [PATCHES] Another VPATH patch for ecpg

pgsql-patches by date

Next:From: Hans-Juergen SchoenigDate: 2006-08-28 16:26:52
Subject: Re: [HACKERS] Performance testing of COPY (SELECT) TO
Previous:From: Tom LaneDate: 2006-08-28 16:16:40
Subject: Re: [PATCHES] Another VPATH patch for ecpg

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group