Re: [PATCHES] Another VPATH patch for ecpg

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: pgsql-hackers(at)postgresql(dot)org, meskes(at)postgresql(dot)org, Alvaro Herrera <alvherre(at)commandprompt(dot)com>
Subject: Re: [PATCHES] Another VPATH patch for ecpg
Date: 2006-08-28 16:16:40
Message-ID: 5723.1156781800@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> Done. New machine is 'bustard'. But I couldn't get Alvaro's patch nor
> Peter's suggestion to work :-( Maybe someone with more vpath-fu than me
> can fix it.

I got it to build fairly easily, but the ecpg regression tests are a mess.
After some fooling around, I'm down to diffs like these in the
preprocessor output files:

116c116
< #line 36 "show.pgc"
---
> #line 36 "/home/tgl/pgsql/src/interfaces/ecpg/test/sql/show.pgc"
119c119
< #line 36 "show.pgc"
---
> #line 36 "/home/tgl/pgsql/src/interfaces/ecpg/test/sql/show.pgc"
122c122
< #line 36 "show.pgc"
---
> #line 36 "/home/tgl/pgsql/src/interfaces/ecpg/test/sql/show.pgc"

AFAICS there is no very good way to deal with this. I'd suggest
providing a way to suppress #line output from the ecpg preprocessor,
but perhaps there is another answer.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2006-08-28 16:26:23 Re: [HACKERS] Performance testing of COPY (SELECT) TO
Previous Message Zoltan Boszormenyi 2006-08-28 16:16:19 Re: [HACKERS] Performance testing of COPY (SELECT) TO

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2006-08-28 16:26:23 Re: [HACKERS] Performance testing of COPY (SELECT) TO
Previous Message Zoltan Boszormenyi 2006-08-28 16:16:19 Re: [HACKERS] Performance testing of COPY (SELECT) TO