Skip site navigation (1) Skip section navigation (2)

Re: BUG #6460: routine my_log2 use incorrect data type ?

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: zoulx1982(at)163(dot)com
Cc: pgsql-bugs(at)postgresql(dot)org
Subject: Re: BUG #6460: routine my_log2 use incorrect data type ?
Date: 2012-02-17 22:27:04
Message-ID: 5689.1329517624@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-bugs
zoulx1982(at)163(dot)com writes:
>  I startup postgres in win server 2008 64-bit with
> shared_buffers=1073741819, but find it doesn't work.

Well, that's hardly the fault of my_log2.  What you should have gotten
is

FATAL:  requested shared memory size overflows size_t

and I do get that when I try that value.  Apparently the overflow check
in mul_size() is broken in your build.   Did you build it yourself, and
if so with which compiler and what compilation options?  If you didn't
build it yourself, where did you get it from?

> size_t in win64 is 8 bytes, so add_size and mul_size can't check overflow,

Sure they can.  Or at least if they can't, it's not because of size_t
being 8 bytes.  That code works fine on every other 64-bit platform.

			regards, tom lane

In response to

Responses

pgsql-bugs by date

Next:From: mark.langsdorfDate: 2012-02-17 22:55:59
Subject: BUG #6462: rpmbuild fails during regression tests on SMP ARM machines
Previous:From: Tom LaneDate: 2012-02-17 17:01:57
Subject: Re: BUG #6461: "-t" deletes primary key

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group