Tatsuo Ishii <t-ishii(at)sra(dot)co(dot)jp> writes:
> Ok. I have tested patches from Bruce. Now tests for bit passed.
> Remaining issues seem that strtol() is broken on SunOS4, not detecting
> an overflow, which causes int4 and some of other tests failure.
Looks like you might also want to use horology-no-DST-before-1970.out.
> Should we use our own strtol()?
Mumble. The memcmp fix was all from well-tested parts, but I don't
think we have a canned test for strtol breakage available. Also,
I believe that the SunOS strtol lossage has been known and tolerated
in previous Postgres releases. Since it's not a regression, I'm going
to change sides and vote with Peter: let's not fix this one now.
regards, tom lane
In response to
pgsql-hackers by date
|Next:||From: Thomas Lockhart||Date: 2001-12-20 03:49:18|
|Subject: datetime and timespan deprecated|
|Previous:||From: Bruce Momjian||Date: 2001-12-20 03:20:42|
|Subject: Re: 7.2 is slow? [compile problem]|
pgsql-patches by date
|Next:||From: Tatsuo Ishii||Date: 2001-12-20 04:25:17|
|Subject: Re: SunOS patch for memcmp() |
|Previous:||From: Christopher Kings-Lynne||Date: 2001-12-20 02:53:56|
|Subject: Geometry patch for freebsd alpha|