Magnus Hagander <magnus(at)hagander(dot)net> writes:
> On Sat, Dec 11, 2010 at 18:46, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> I think we can just #define the other cases as zeroes. I'm not sure why
>> you think that's an issue for open --- the privileges don't exist.

> Hmm. I was/am worried about any case that specifies *just* one of the
> permissions that don't exist. That'll leave it at zero, whereas the
> correct one might be the user-only version of whatever (read/write)
> was given.

If we didn't specify the "user" read or write privilege, we shouldn't
get it.

What are the values of _S_IREAD and _S_IWRITE, anyway?  I'm still
wondering how come the previous coding with hardwired constants
behaved correctly.

			regards, tom lane

In response to

• Re: [COMMITTERS] pgsql: Use symbolic names not octal constants for file permission flags at 2010-12-11 17:55:43 from Magnus Hagander

Responses

• Re: [COMMITTERS] pgsql: Use symbolic names not octal constants for file permission flags at 2010-12-12 16:16:46 from Tom Lane

pgsql-hackers by date

Next:	From: Robert Haas	Date: 2010-12-11 18:15:45
	Subject: Re: create tablespace fails silently, or succeeds improperly
Previous:	From: Magnus Hagander	Date: 2010-12-11 17:55:43
	Subject: Re: [COMMITTERS] pgsql: Use symbolic names not octal constants for file permission flags

pgsql-committers by date

Next:	From: Tom Lane	Date: 2010-12-11 18:11:29
	Subject: pgsql: Provide a complete set of file-permission-bit macros inwin32.h.
Previous:	From: Magnus Hagander	Date: 2010-12-11 17:55:43
	Subject: Re: [COMMITTERS] pgsql: Use symbolic names not octal constants for file permission flags