Re: [HACKERS] Hot Standby utility and administrator functions

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Simon Riggs <simon(at)2ndQuadrant(dot)com>
Cc: Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, pgadmin-hackers(at)postgresql(dot)org, pgsql-general(at)postgresql(dot)org
Subject: Re: [HACKERS] Hot Standby utility and administrator functions
Date: 2008-10-20 22:45:31
Message-ID: 5600.1224542731@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers pgsql-general pgsql-hackers

Simon Riggs <simon(at)2ndQuadrant(dot)com> writes:
> On Mon, 2008-10-20 at 17:44 -0300, Alvaro Herrera wrote:
>> That's been "extended with an epoch counter" per the docs; I don't think
>> that's appropriate for the new functions, is it?

> I assumed it was, so you can subtract them easily.

> It can be done either way, I guess. Happy to provide what people need. I
> just dreamed up a few that sounded useful.

I don't think you should be inventing new functions without clear
use-cases in mind. Depending on what the use is, I could see either the
xid or the txid definition as being *required*.

In any case, do not use the wrong return type for the definition you're
implementing.

regards, tom lane

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Gevik Babakhani 2008-10-20 22:59:08 Re: extending functionality strategy
Previous Message Simon Riggs 2008-10-20 20:56:06 Re: [GENERAL] [HACKERS] Hot Standby utility and administrator functions

Browse pgsql-general by date

  From Date Subject
Next Message Tom Lane 2008-10-20 23:02:04 Re: Slow delete with with cascading foreign keys
Previous Message cyw 2008-10-20 22:06:41 Can PL/PGSQL function return multiple SETOFs

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2008-10-20 22:54:04 Re: Re: [COMMITTERS] pgsql: Properly access a buffer's LSN using existing access macros
Previous Message Lawrence, Ramon 2008-10-20 22:42:49 Proposed Patch to Improve Performance of Multi-Batch Hash Join for Skewed Data Sets