| From: | Teodor Sigaev <teodor(at)sigaev(dot)ru> |
|---|---|
| To: | Anastasia Lubennikova <a(dot)lubennikova(at)postgrespro(dot)ru>, pgsql-hackers(at)postgresql(dot)org, Jeff Janes <jeff(dot)janes(at)gmail(dot)com> |
| Subject: | Re: [PATCH] Microvacuum for gist. |
| Date: | 2015-09-16 15:36:21 |
| Message-ID: | 55F98C75.3070600@sigaev.ru |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> But It seems to me that it would be better to rewrite all mentions of
> TupleDelete to MultiDelete in gist code.
Sure. Patch is attached, and it changes WAL format, so be carefull with testing.
Please, have a look.
Also in attach scripts reproduce bug from Jeff's report:
g.pl - creates and fills test table
w.pl - worker, could run in several session
Usage
perl g.pl | psql contrib_regression
perl w.pl | psql contrib_regression | grep 'UPDATE 0'
and killall -9 postgres while w.pl is running. Recovery will fail with high
probability.
Thank you, Jeff, for report.
--
Teodor Sigaev E-mail: teodor(at)sigaev(dot)ru
WWW: http://www.sigaev.ru/
| Attachment | Content-Type | Size |
|---|---|---|
| gist_delete.patch | text/plain | 2.1 KB |
| g.pl | application/x-perl | 270 bytes |
| w.pl | application/x-perl | 183 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nicolas Barbier | 2015-09-16 15:53:39 | Re: [PROPOSAL] Covering + unique indexes. |
| Previous Message | Alvaro Herrera | 2015-09-16 15:32:38 | Re: pltcl: sentence improvement |