| From: | Teodor Sigaev <teodor(at)sigaev(dot)ru> |
|---|---|
| To: | Paul A Jungwirth <pj(at)illuminatedcomputing(dot)com>, Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Review: GiST support for UUIDs |
| Date: | 2015-09-14 15:57:54 |
| Message-ID: | 55F6EE82.8080209@sigaev.ru |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Patch looks perfect but it's still needed some work.
0) rebase to current HEAD (done, in attach)
1) UUIDSIZE -> UUID_LEN (it's defined in utils/uuid.h, done)
2)
static double
uuid2num(const pg_uuid_t *i)
{
return *((uint64 *)i);
}
It isn't looked as correct transformation for me. May be, it's better
to transform to numeric type (UUID looks like a 16-digit hexademical number)
and follow gbt_numeric_penalty() logic (or even call directly).
--
Teodor Sigaev E-mail: teodor(at)sigaev(dot)ru
WWW: http://www.sigaev.ru/
| Attachment | Content-Type | Size |
|---|---|---|
| btree_gist_uuid_2.patch | text/plain | 120.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2015-09-14 16:02:08 | Re: Review: GiST support for UUIDs |
| Previous Message | Andres Freund | 2015-09-14 15:41:42 | Re: Move PinBuffer and UnpinBuffer to atomics |