From: | Petr Jelinek <petr(at)2ndquadrant(dot)com> |
---|---|
To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
Cc: | Peter Eisentraut <peter_e(at)gmx(dot)net>, Jeff Janes <jeff(dot)janes(at)gmail(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Jaime Casanova <jaime(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Tomas Vondra <tv(at)fuzzy(dot)cz> |
Subject: | Re: TABLESAMPLE patch |
Date: | 2015-04-22 19:31:38 |
Message-ID: | 5537F71A.1090802@2ndquadrant.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 19/04/15 01:24, Michael Paquier wrote:
> On Sat, Apr 18, 2015 at 8:38 PM, Michael Paquier
> <michael(dot)paquier(at)gmail(dot)com> wrote:
>> On Fri, Apr 17, 2015 at 10:54 PM, Petr Jelinek wrote:
>>> On 10/04/15 06:46, Michael Paquier wrote:
>>>> 13) Some regression tests with pg_tablesample_method would be welcome.
>>>
>>> Not sure what you mean by that.
>>
>> I meant a sanity check on pg_tablesample_method to be sure that
>> tsminit, tsmnextblock and tsmnexttuple are always defined as they are
>> mandatory functions. So the idea is to add a query like and and to be
>> sure that it returns no rows:
>> SELECT tsmname FROM pg_tablesample_method WHERE tsminit IS NOT NULL OR
>> tsmnextblock IS NOT NULL OR tsmnexttuple IS NOT NULL;
>
> Yesterday was a long day. I meant IS NULL and not IS NOT NULL, but I
> am sure you guessed it that way already..
>
Yes I guessed that and it's very reasonable request, I guess it should
look like the attached (I don't want to send new version of everything
just for this).
--
Petr Jelinek http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
Attachment | Content-Type | Size |
---|---|---|
0007-tablesample-add-catalog-regression-test.patch | text/x-diff | 2.2 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Heikki Linnakangas | 2015-04-22 19:34:05 | Re: Streaming replication and WAL archive interactions |
Previous Message | Alvaro Herrera | 2015-04-22 19:29:06 | Re: cache lookup error for shell type creation with incompatible output function (DDL deparsing bug) |