Re: Fix for pg_upgrade and invalid indexes

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Fix for pg_upgrade and invalid indexes
Date: 2013-03-29 22:35:08
Message-ID: 5501.1364596508@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Bruce Momjian <bruce(at)momjian(dot)us> writes:
> Attached is a patch that implements the suggested pg_upgrade changes of
> not copying invalid indexes now that pg_dump doesn't dump them. This
> should be backpatched back to 8.4 to match pg_dump. It might require
> release note updates; not sure. Previously pg_upgrade threw an error
> if invalid indexes exist, but only since February, when we released the
> pg_upgrade fix to do this. You can see the majority of this patch is
> removing that check.

Surely that should be LEFT JOIN not RIGHT JOIN?

regards, tom lane

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Andres Freund 2013-03-29 22:40:28 Re: Fix for pg_upgrade and invalid indexes
Previous Message Bruce Momjian 2013-03-29 20:57:06 Fix for pg_upgrade and invalid indexes

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2013-03-29 22:40:28 Re: Fix for pg_upgrade and invalid indexes
Previous Message Michael Paquier 2013-03-29 21:49:15 Re: Getting to 9.3 beta