From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
Cc: | Brendan Jurd <direvus(at)gmail(dot)com>, pgsql-hackers(at)postgreSQL(dot)org |
Subject: | Re: [COMMITTERS] pgsql: Remove typename from A_Const. |
Date: | 2008-04-29 20:15:59 |
Message-ID: | 5500.1209500159@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> Tom Lane escribi:
>> I'm thinking is that we should get rid of the ::float8 decoration too,
>> and thereby be able to revert some of the ugly code added elsewhere such
>> as guc.c.
> Hmm, I'm not sure but I think the typecast is needed in the guc.c code
> in order to pass the fact that the Const is an Interval.
Yeah, I had just found that out --- it's not so much that we care that
it's an interval, as that the original input might have had typmod
restrictions that need to be applied to the interval value. Definitely
a kluge to support a corner case ...
Anyway, I'm in the middle of testing removal of the ::float8 cast
--- we can at least simplify parse_type.c's handling of typmods here.
I also see that we can eliminate some manual construction of A_Const's
in gram.y, since makeFloatConst and friends no longer do any unwanted
extra stuff.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2008-04-29 20:44:49 | pgsql: Some minor further cleanup around A_Const. |
Previous Message | Alvaro Herrera | 2008-04-29 20:07:38 | Re: [COMMITTERS] pgsql: Remove typename from A_Const. |
From | Date | Subject | |
---|---|---|---|
Next Message | Thomas Mueller | 2008-04-29 20:18:48 | Re: Protection from SQL injection |
Previous Message | Alvaro Herrera | 2008-04-29 20:07:38 | Re: [COMMITTERS] pgsql: Remove typename from A_Const. |