Re: A bug with ALTER TABLE SET WITHOUT OIDS in CVS HEAD

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: KaiGai Kohei <kaigai(at)ak(dot)jp(dot)nec(dot)com>
Cc: Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: A bug with ALTER TABLE SET WITHOUT OIDS in CVS HEAD
Date: 2008-11-27 15:23:05
Message-ID: 5473.1227799385@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

KaiGai Kohei <kaigai(at)ak(dot)jp(dot)nec(dot)com> writes:
> If my understanding is correct, the following patch can fix the matters.

> ! if (ExecContextForcesOids(ps, &hasoid) &&
> ! hasoid != tupdesc->tdhasoid)
> return false;
> --- 243,249 ----
> ! if (ExecContextForcesOids(ps, &hasoid))
> return false;

This isn't fixing anything, it's just making the executor stick its
head in the sand.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Emmanuel Cecchet 2008-11-27 16:09:43 Re: Fwd: [PATCHES] Auto Partitioning Patch - WIP version 1
Previous Message Jaime Casanova 2008-11-27 15:12:13 Re: Fwd: [PATCHES] Auto Partitioning Patch - WIP version 1