Missing FIN_CRC32 calls in logical replication code

From: Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>
To: PostgreSQL-development <pgsql-hackers(at)postgreSQL(dot)org>, Andres Freund <andres(at)2ndQuadrant(dot)com>
Subject: Missing FIN_CRC32 calls in logical replication code
Date: 2014-10-27 10:51:44
Message-ID: 544E23C0.8090605@vmware.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

replication/slot.c and replication/logical/snapbuild.c use a CRC on the
physical slot and snapshot files. It uses the same algorithm as used
e.g. for the WAL. However, they are not doing the finalization step,
FIN_CRC32() on the calculated checksums. Not that it matters much, but
it's a bit weird and inconsistent, and was probably an oversight.

- Heikki

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Atri Sharma 2014-10-27 11:06:07 Re: proposal: CREATE DATABASE vs. (partial) CHECKPOINT
Previous Message Pavel Stehule 2014-10-27 10:51:01 Re: Function array_agg(array)