Re: Revised patch for fixing archiver shutdown behavior

Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> Something I'm still wondering is about the archiver/logger combination.
> What happens if a postmaster is stopped by the user and the archiver is
> still running, and the user starts a new postmaster? This would launch
> a new archiver and logger; and there are now two loggers possibly
> writing to the same files, and truncated log lines could occur.

I'm not nearly as worried about that as I am about the prospect of
two concurrent archivers :-(

There was discussion of having a lock file for the archiver, but
it's still an open issue. I'm not sure how to solve the problem
of stale lockfiles --- unlike the postmaster, the archiver can't
assume that it's the only live process with the postgres userid.
For example, after a system crash-and-restart, it's entirely
likely that the PID formerly held by the archiver is now held
by the bgwriter, making the lockfile (if any) look live.

Maybe we should go back to the plan of having the postmaster
wait for the archiver to exit.

regards, tom lane