Re: Small syntax error in fmgr.h

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Martin Pitt <mpitt(at)debian(dot)org>
Cc: PostgreSQL Bugs <pgsql-bugs(at)postgresql(dot)org>
Subject: Re: Small syntax error in fmgr.h
Date: 2009-10-29 14:36:25
Message-ID: 5345.1256826985@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

Martin Pitt <mpitt(at)debian(dot)org> writes:
> https://launchpad.net/bugs/458020 reports a small syntax error in
> ./src/include/fmgr.h:338:

> extern int no_such_variable

> The trailing semicolon is missing:

This is not a bug. You are supposed to write a semicolon after the
call of PG_MODULE_MAGIC. If we put a semicolon into the macro value,
it would break every single correct usage (at least under compilers
that are picky about empty statements outside functions).

The same goes for PG_FUNCTION_INFO_V1.

regards, tom lane

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message Alvaro Herrera 2009-10-29 14:36:51 Re: Small syntax error in fmgr.h
Previous Message Euler Taveira de Oliveira 2009-10-29 14:17:36 Re: BUG #5145: Complex query with lots of LEFT JOIN causes segfault