| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Simon Riggs <simon(at)2ndquadrant(dot)com> |
| Cc: | pgsql-patches(at)postgresql(dot)org |
| Subject: | Re: set_ps_display during recovery |
| Date: | 2007-09-30 14:28:27 |
| Message-ID: | 5333.1191162507@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-patches |
Simon Riggs <simon(at)2ndquadrant(dot)com> writes:
> On Sat, 2007-09-29 at 14:34 -0400, Tom Lane wrote:
>> Hmm, not right there, because we don't know that the file actually
>> exists yet. Applied with modifications ...
> Double hmmm, that means when we are waiting for file X in pg_standby the
> ps display will still show "recovering X-1". I'd prefer to set ps before
> the call to RestoreArchivedFile(), since that is where the wait occurs.
> I got that wrong myself.
Well, if you think that's an important time component --- which it could
be in archive situations, I guess --- there should be a separate PS
display state for it. Perhaps "fetching XXX" vs "restoring XXX"?
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Simon Riggs | 2007-09-30 14:34:58 | Re: set_ps_display during recovery |
| Previous Message | Michael Meskes | 2007-09-30 11:39:45 | Re: ecpg thead-safe memory management + cleanup |