Skip site navigation (1) Skip section navigation (2)

Re: Code not compiling since 19d5486 due to concatenate operators in macros

From: Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>
To: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Hiroshi Inoue <inoue(at)tpf(dot)co(dot)jp>
Cc: PostgreSQL mailing lists <pgsql-odbc(at)postgresql(dot)org>
Subject: Re: Code not compiling since 19d5486 due to concatenate operators in macros
Date: 2013-10-28 10:53:33
Message-ID: 526E422D.2050604@vmware.com (view raw or flat)
Thread:
Lists: pgsql-odbc
On 28.10.2013 10:10, Michael Paquier wrote:
> Hi all,
> (resending patch as it looks that it was stuck in administration queue
> of this ML...)
>
> I noticed this morning that ODBC does not compile correctly since
> commit 19d5486 due to some macros using concatenate operators used
> with CORR_STRCPY and CORR_VALCPY in psqlodbc.c and connection.c.
>
> In the case of CORR_VALCPY the macro simply needs to copy a field one
> by one, and for CORR_STRCPY only a string is copied, so concatenate
> operators are not necessary IMO. Please find a patch fixing that by
> removing the unnecessary operators.

Thanks, committed to fix the build.

Hiroshi, I didn't understand the point of that change in the first 
place. The old memcpy method of copying these objects seemed fine to me. 
Can you elaborate?

PS. I just noticed that the email address in your git commit messages is 
misspelled, "inoue(at)tpf(dot)co(dot)p". Check your .gitconfig file.

- Heikki


In response to

Responses

pgsql-odbc by date

Next:From: Hiroshi InoueDate: 2013-10-29 01:10:05
Subject: Re: Code not compiling since 19d5486 due to concatenate operators in macros
Previous:From: Michael PaquierDate: 2013-10-28 08:10:46
Subject: Code not compiling since 19d5486 due to concatenate operators in macros

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group