Skip site navigation (1) Skip section navigation (2)

Re: Signing off of patches (was Re: Not ready for 8.3)

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
Cc: Andrew Dunstan <andrew(at)dunslane(dot)net>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Signing off of patches (was Re: Not ready for 8.3)
Date: 2007-05-19 01:59:11
Message-ID: 5226.1179539951@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-hackers
Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> In order to make patch review more effective, perhaps we could use some
> tools to help us.  How about
> http://www.chipx86.com/blog/?p=222

I kinda think this is emphasizing the wrong end of the process.  "Code
everything, then ask for comments" is about as far away from the correct
mindset as one can readily get.

I'd like to see something that emphasizes review and feedback at the
stages of germinal idea, rough functional spec, implementation concept,
etc.  Reviewing the actual code is good too, but if that's the first
stage that you ask for help at, you are off in the wrong direction;
particularly so if you're a larval Postgres hacker.

			regards, tom lane

In response to

Responses

pgsql-hackers by date

Next:From: Karl O. PincDate: 2007-05-19 02:48:20
Subject: Re: COPY into a view; help w. design & patch
Previous:From: Alvaro HerreraDate: 2007-05-19 01:45:07
Subject: Re: Signing off of patches (was Re: Not ready for 8.3)

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group