Skip site navigation (1) Skip section navigation (2)

Re: Minor irritant with comment parsing in a function (SQL)

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: Richard Huxton <dev(at)archonet(dot)com>, pgsql-bugs(at)postgresql(dot)org
Subject: Re: Minor irritant with comment parsing in a function (SQL)
Date: 2003-10-08 21:33:11
Message-ID: 5159.1065648791@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-bugs
Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
> The bug here is that the scanner doesn't know that a newline (or end of
> input) is a required as part of a -- comment.

I think the minimum-damage place to fix this is by requiring \n after
{comment} in the horiz_whitespace rule.  As is, it's possible for
xqcat to match to a second quote that is in the body of a -- comment.

			regards, tom lane

In response to

Responses

pgsql-bugs by date

Next:From: Joe ConwayDate: 2003-10-08 21:58:13
Subject: Re: Bug Report
Previous:From: Peter EisentrautDate: 2003-10-08 20:36:14
Subject: Re: pg_resetxlog and pgscripts italian translation

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group