Re: [COMMITTERS] pgsql: Allow external recovery_config_directory

From: Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>
To: Simon Riggs <simon(at)2ndQuadrant(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [COMMITTERS] pgsql: Allow external recovery_config_directory
Date: 2013-03-27 21:05:26
Message-ID: 51535F16.2020602@vmware.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On 27.03.2013 20:02, Simon Riggs wrote:
> On 27 March 2013 17:50, Heikki Linnakangas<hlinnakangas(at)vmware(dot)com> wrote:
>> Imagine that you have set recovery_config_directory='/foo/' in the master
>> server. Now you want to set up a standby, so you do:'
>>
>> pg_basebackup -D data-standby -R
>>
>> With the -R option, pg_basebackup creates data-standby/recovery.conf to
>> point to the master, with standby_mode='on'. But if you start the server, it
>> will start up as a master, not as a standby, because
>> recovery_config_directory points elsewhere.
>
> Yeh, I get it.
>
> Same argument applies to all conf files, not just recovery.conf.
>
> Sounds like the patch to add -R to pg_basebackup should be revoked as
> being not well thought out. Or it should be fixed, in which case this
> works the same.

What exactly was wrong with pg_basebackup -R, without
recovery_config_directory?

- Heikki

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Kevin Grittner 2013-03-27 21:13:49 pgsql: Fix pasto which broke docs build.
Previous Message Heikki Linnakangas 2013-03-27 20:06:51 pgsql: Fix buffer pin leak in heap update redo routine.

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2013-03-27 21:06:15 Re: pkg-config files for libpq and ecpg
Previous Message Peter Eisentraut 2013-03-27 20:53:12 Re: pkg-config files for libpq and ecpg