From:
Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>
To:
Andres Freund <andres(at)2ndquadrant(dot)com>
Cc:
Michael Paquier <michael(dot)paquier(at)gmail(dot)com>,
Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>,
hlinnakanga(at)awork2(dot)anarazel(dot)de,
PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject:
Re: Re: Slave enters in recovery and promotes when WAL
stream with master is cut + delay master/slave
Date:
2013-01-17 15:18:14
Message-ID:
50F81636.6000701@vmware.com (view raw or flat )
Thread:
2013-01-17 04:47:41 from Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
2013-01-17 10:54:00 from Andres Freund <andres(at)2ndquadrant(dot)com>
2013-01-17 13:05:15 from Andres Freund <andres(at)2ndquadrant(dot)com>
2013-01-17 15:18:14 from Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>
2013-01-17 15:23:44 from Andres Freund <andres(at)2ndquadrant(dot)com>
2013-01-17 15:42:25 from Andres Freund <andres(at)2ndquadrant(dot)com>
2013-01-17 16:33:42 from Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>
2013-01-17 16:42:25 from Andres Freund <andres(at)2ndquadrant(dot)com>
2013-01-17 16:50:35 from Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>
2013-01-17 16:55:07 from Andres Freund <andres(at)2ndquadrant(dot)com>
2013-01-17 17:29:52 from Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>
2013-01-17 17:35:20 from Andres Freund <andres(at)2ndquadrant(dot)com>
2013-01-17 18:05:47 from Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
2013-01-17 18:08:30 from Andres Freund <andres(at)2ndquadrant(dot)com>
2013-01-17 19:57:28 from Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>
2013-01-17 21:49:22 from Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>
2013-01-17 22:07:28 from Andres Freund <andres(at)2ndquadrant(dot)com>
2013-01-17 23:24:31 from Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
2013-01-17 23:48:44 from Andres Freund <andres(at)2ndquadrant(dot)com>
2013-01-18 00:33:21 from Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
2013-01-18 14:20:35 from Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
2013-01-18 00:35:23 from Andres Freund <andres(at)2ndquadrant(dot)com>
2013-01-18 09:20:57 from Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>
2013-01-22 00:06:45 from Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
2013-01-22 00:25:05 from Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
Lists:
pgsql-hackers
On 17.01.2013 15:05, Andres Freund wrote:
> On 2013-01-17 13:47:41 +0900, Michael Paquier wrote:
>> I think that bug has been introduced by commit 7fcbf6a.
>> Before splitting xlog reading as a separate facility things worked
>> correctly.
>> There are also no delay problems before this commit.
>
> Ok, my inkling proved to be correct, its two related issues:
>
> a ) The error handling in XLogReadRecord is inconsistent, it doesn't
> always reset the necessary things.
>
> b) ReadRecord: We cannot not break out of the retry loop in readRecord
> just so, just removing the break seems correct.
>
> c) ReadRecord: (minor): We should log an error even if errormsg is not
> set, otherwise we wont jump out far enough.
>
> I think at least a) and b) is the result of merges between development
> of different people, sorry for that.
Got a patch?
- Heikki
In response to
Responses
pgsql-hackers by date
Next :From: Tom LaneDate: 2013-01-17 15:19:23Subject : Re: Hot Standby conflict resolution handlingPrevious :From : Heikki LinnakangasDate : 2013-01-17 15:14:04Subject : Re: Removing PD_ALL_VISIBLE
