Skip site navigation (1) Skip section navigation (2)

Re: review: pgbench - aggregation of info written into log

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Tatsuo Ishii <ishii(at)postgresql(dot)org>
Cc: tv(at)fuzzy(dot)cz, pgsql-hackers(at)postgresql(dot)org
Subject: Re: review: pgbench - aggregation of info written into log
Date: 2013-01-16 23:38:25
Message-ID: 50F739F1.9060602@dunslane.net (view raw or flat)
Thread:
Lists: pgsql-hackers
On 01/16/2013 05:59 PM, Tatsuo Ishii wrote:
> Hi,
>
> I'm looking into this as a committer.  It seems that this is the
> newest patch and the reviewer(Pavel) stated that it is ready for
> commit. However, I noticed that this patch adds a Linux/UNIX only
> feature(not available on Windows). So I would like to ask cores if
> this is ok or not.

I haven't been following the thread, but if the complaint is that 
Windows doesn't have accurate high-resolution timers, which is what it 
kinda looks like from the rest of your message, then it's not true. 
Every version since Windows2000 has had 
QueryPerformanceCounter()/QueryPerformanceFrequency(). And we use it: 
see src/include/portability/instr_time.h

If that's not the problem, then can someone please point me at the 
message that sets the problem out clearly, or else just recap it?

cheers

andrew



In response to

Responses

pgsql-hackers by date

Next:From: Robert HaasDate: 2013-01-16 23:42:33
Subject: Re: Event Triggers: adding information
Previous:From: Stephen FrostDate: 2013-01-16 23:31:44
Subject: Re: [PATCH] COPY .. COMPRESSED

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group