Skip site navigation (1) Skip section navigation (2)

Re: pg_dump --pretty-print-views

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: David Fetter <david(at)fetter(dot)org>, Marko Tiikkaja <pgmail(at)joh(dot)to>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pg_dump --pretty-print-views
Date: 2013-01-10 17:31:07
Message-ID: 50EEFADB.9090809@dunslane.net (view raw or flat)
Thread:
Lists: pgsql-hackers 
On 01/10/2013 12:09 PM, Tom Lane wrote:


> Now, we could consider changing the "safe" mode so that it tries to
> provide nice whitespace/line breaks while not risking removal of
> parentheses.  But that would be a totally different patch, and I'm
> not sure how much it would address Marko's desires anyway.


I think there's a very good case for breaking the nexus between 
PRETTYFLAG_PAREN and PRETTYFLAG_INDENT+line wrapping for views. Only 
PRETTYFLAG_PAREN affects the safety issue. The others are just about 
white space in safe places.

cheers

andrew

In response to

Responses

pgsql-hackers by date

Next:From: Tom LaneDate: 2013-01-10 17:35:00
Subject: Re: pg_dump --pretty-print-views
Previous:From: Kevin GrittnerDate: 2013-01-10 17:26:06
Subject: Re: proposal: Set effective_cache_size to greater of .conf value, shared_buffers

Privacy Policy | About PostgreSQL
Copyright © 1996-2013 The PostgreSQL Global Development Group