Skip site navigation (1) Skip section navigation (2)

Re: PL/perl should fail on configure, not make

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Josh Berkus <josh(at)agliodbs(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Tim Bunce <Tim(dot)Bunce(at)pobox(dot)com>
Subject: Re: PL/perl should fail on configure, not make
Date: 2013-01-09 21:49:30
Message-ID: 50EDE5EA.909@dunslane.net (view raw or flat)
Thread:
Lists: pgsql-hackers
On 01/09/2013 04:12 PM, Tom Lane wrote:
> Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
>> On 01/09/2013 10:16 AM, Tom Lane wrote:
>>> Actually, if we were to try to clean this up, I'd suggest moving that
>>> logic into the configure script --- it's not apparent to me why it's
>>> a good idea to be changing configure-determined values in the Makefile.
>>> But in any case this would have to be done by somebody who's in a
>>> position to test on affected platforms.
>> Here's a patch which does that and produces configure traces like this
>> on Mingw:
>>      checking for Perl archlibexp... C:/Perl/lib
>>      checking for Perl privlibexp... C:/Perl/lib
>>      checking for Perl useshrplib... true
>>      checking for flags to link embedded Perl... -LC:/Perl/lib/CORE -lperl512
>> which seems to be what we want.
>> Given that, you should be able to write a reasonably portable configure
>> test for library presence.
> Looks good.  If you're happy with that then I can undertake to add a
> libperl.so probe based on AC_TRY_LINK with the unmodified value of
> $perl_embed_ldflags.
>


Go for it.

cheers

andrew



In response to

Responses

pgsql-hackers by date

Next:From: Simon RiggsDate: 2013-01-09 21:52:31
Subject: Re: Index build temp files
Previous:From: Bruce MomjianDate: 2013-01-09 21:43:27
Subject: Re: Reducing size of WAL record headers

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group