On 08.01.2013 23:00, Andres Freund wrote:
>> Note that the xlogreader facility doesn't need any more emulation. I'm quite
>> satisfied with that part of the patch now. However, the rmgr desc routines
>> do, and I'm not very happy with those. Not sure what to do about it. As you
>> said, we could add enough infrastructure to make them compile in frontend
>> context, or we could try to make them rely less on backend functions.
>
> Which emulation needs are you missing in the desc routines besides
> relpathbackend() and timestamptz_to_str()? pfree() is "just" needed
> because its used to free the result of relpathbackend(). No own pallocs,
> no ereport ...
Nothing besides those, those are the stuff I was referring to.
- Heikki
In response to
Responses
pgsql-hackers by date
| Next: | From: Bruce Momjian | Date: 2013-01-08 21:04:54 |
| Subject: Re: pg_upgrade regression test litters the source tree
with log files |
| Previous: | From: Andres Freund | Date: 2013-01-08 21:00:10 |
| Subject: Re: [PATCH 2/5] Make relpathbackend return a statically
result instead of palloc()'ing it |