Skip site navigation (1) Skip section navigation (2)

Re: PATCH: optimized DROP of multiple tables within a transaction

From: Tomas Vondra <tv(at)fuzzy(dot)cz>
To: pgsql-hackers(at)postgresql(dot)org
Subject: Re: PATCH: optimized DROP of multiple tables within a transaction
Date: 2013-01-06 03:35:30
Message-ID: 50E8F102.6020203@fuzzy.cz (view raw or flat)
Thread:
Lists: pgsql-hackers
On 4.1.2013 17:42, Robert Haas wrote:
> On Mon, Dec 31, 2012 at 11:51 AM, Tomas Vondra <tv(at)fuzzy(dot)cz> wrote:
>> I thought I followed the conding style - which guidelines have I broken?
> 
> +	/* If there are no non-local relations, then we're done. Release the memory
> +	 * and return. */
> 
> Multi-line comments should start with a line containing only /* and
> end with a line containing only */.
> 
> +DropRelFileNodeAllBuffers(RelFileNodeBackend * rnodes, int nnodes)
> and
> +rnode_comparator(const void * p1, const void * p2)
> 
> The extra spaces after the asterisks should be removed.
> 
> +void smgrdounlinkall(SMgrRelation * rels, int nrels, bool isRedo)
> +{
> 
> void should be on a line by itself.
> 
> Sorry to nitpick.

No, thanks for the nitpicking! Code style is important.

> As for BSEARCH_LIMIT, I don't have a great idea - maybe just
> DROP_RELATIONS_BSEARCH_LIMIT?

Sounds good. I've changed the name and fixed the codestyle issues in the
attached version of the patch.

Tomas

Attachment: drop-in-transaction-v6.patch
Description: text/plain (8.9 KB)

In response to

Responses

pgsql-hackers by date

Next:From: Tomas VondraDate: 2013-01-06 04:03:38
Subject: Re: PATCH: Split stats file per database WAS: autovacuum stress-testing our system
Previous:From: Tomas VondraDate: 2013-01-06 03:13:12
Subject: Re: too much pgbench init output

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group